They're fun party games, but there are tons of other games I would much rather play.
I don't really think of them as being equivalent to playing a musical instrument. It's just a game. I don't get the people who say "you should be playing a real guitar instead." That's like saying I should beat a real cop to death with a dildo instead of playing GTA.